Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thank you for this awesome Svelte wrapper for AG Grid. I saw you have a WIP svelte4 branch that was very close to working. I added a few commits on top of yours to get everything working.
Right now tests pass and I have been able to use this version in a Svelte 4 project, but there are a few issues caught by type-aware linting:
I wanted to get direction from you on how you'd like to resolve these errors. I am guessing this is where you stopped your work on the
svelte4
branch. It has been a long time since I worked with Typescript, but it appears that resolving these issues will take some work.What do you think?